mik-laj commented on a change in pull request #18309:
URL: https://github.com/apache/airflow/pull/18309#discussion_r711607273



##########
File path: airflow/utils/log/log_reader.py
##########
@@ -54,6 +57,8 @@ def read_log_chunks(
         contain information about the task log which can enable you read logs 
to the
         end.
         """

Review comment:
       What do you think about using ti.task.is_dummy to check if an operator 
class is inheriting from DummyOperator?
   See:
   
https://github.com/apache/airflow/blob/a54f8d6b0ce9fd2a2387ccbc11f543d86212ca35/airflow/serialization/serialized_objects.py#L484
   
https://github.com/apache/airflow/blob/a54f8d6b0ce9fd2a2387ccbc11f543d86212ca35/airflow/www/views.py#L1240-L1242




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to