edwardwang888 commented on pull request #17575:
URL: https://github.com/apache/airflow/pull/17575#issuecomment-922540200


   > > We install that in Dockerfile so we have it while running tests
   > 
   > Agree. The "test" environment has all the deps in - including pandas and 
numpy. The "test" dependency ([devel_all] extra) defines all things needed to 
run tests.
   > 
   > I think while numpy is not needed as "airflow" dependency, it's perfectly 
fine to have it as "test airflow" dependency.
   
   @kaxil @potiuk Thanks for the feedback. The reason I ask is because of the 
discussion here: 
https://github.com/apache/airflow/pull/18343#discussion_r711648377. For the 
test environment there is no issue as you've mentioned, so I guess the concern 
there is about the local development environment? Of course, if you run the 
test locally and numpy is missing, you can just install it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to