ashb commented on a change in pull request #5200: [AIRFLOW-4401] Use managers 
for Queue synchronization
URL: https://github.com/apache/airflow/pull/5200#discussion_r279339857
 
 

 ##########
 File path: airflow/contrib/executors/kubernetes_executor.py
 ##########
 @@ -694,8 +698,8 @@ def start(self):
         # 
https://github.com/kubernetes-client/python/blob/master/kubernetes/docs
         # /CoreV1Api.md#list_namespaced_pod
         KubeResourceVersion.reset_resource_version()
-        self.task_queue = Queue()
-        self.result_queue = Queue()
+        self.task_queue = self._manager.Queue()
 
 Review comment:
   And here maybe we could use a multiprocessing.JoinableQueue instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to