ashb commented on a change in pull request #5134: [AIRFLOW-4159] Add support
for additional static labels for kubernetes
URL: https://github.com/apache/airflow/pull/5134#discussion_r279380934
##########
File path: tests/contrib/executors/test_kubernetes_executor.py
##########
@@ -627,6 +628,13 @@ def test_get_configmaps(self):
configmaps = worker_config._get_configmaps()
self.assertListEqual(['configmap_a', 'configmap_b'], configmaps)
+ def test_get_labels(self):
+ worker_config = WorkerConfiguration(self.kube_config)
+ labels = worker_config._get_labels({
+ 'dag_id': 'dag_id',
+ })
+ self.assertEqual({'my_label': 'label_id', 'dag_id': 'dag_id'}, labels)
Review comment:
Could you add another check about behaviour of dynamic labels vs static
label to make sure we get the right one out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
