[GitHub] [airflow] eladkal commented on pull request #18456: Proper handling of Account URL custom conn field in AzureBatchHook

Thu, 23 Sep 2021 00:24:09 -0700 


eladkal commented on pull request #18456:
URL: https://github.com/apache/airflow/pull/18456#issuecomment-925564039


   Used the code in your branch and tests are failing (like they do in the CI)
   ![Screen Shot 2021-09-23 at 10 00 
54](https://user-images.githubusercontent.com/45845474/134466394-27f85ae0-f9ac-44ea-aec2-878fda522dc2.png)
   
   In the PR you are changing only the hook. Shouldn't the operator test 
connection be changed as well?
   
https://github.com/apache/airflow/blob/6dbeb82eef263f5f56b46fbb4a9140a288bddd23/tests/providers/microsoft/azure/operators/test_azure_batch.py#L63-L96
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to