wc-s opened a new pull request #18481: URL: https://github.com/apache/airflow/pull/18481
<!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> closes: #18400 The change allows adding different custom pod annotations to the different airflow components (whereas the current chart can only add the same set of custom pod annotations to all airflow components). Some notes: - The per-component pod annotations take precedence over the global pod annotations injected via `.Values.airflowPodAnnotations` - I've only added it to components that already currently support `airflowPodAnnotations`, which excludes `redis` etc. I don't know why we have `airflowPodAnnotations` in some components but not in others, but I want to just continue to convention to keep things clean. - Added annotations test for `triggerer` as well. - Added 2 new test cases, one to test the basic functionality, and one to test the precedence. There are some copy-paste between the two tests but I think there is no need for further abstraction or code-reuse because YAGNI. - Also refactored the existing ServiceAccount annotations test to make it IMO simpler and more readable. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
