uranusjr commented on a change in pull request #16980:
URL: https://github.com/apache/airflow/pull/16980#discussion_r715243679
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -453,7 +453,7 @@ def make_unique_pod_id(pod_id: str) -> str:
# Strip trailing '-' and '.' as they can't be followed by '.'
trimmed_pod_id = pod_id[:MAX_LABEL_LEN].rstrip('-.')
- safe_pod_id = f"{trimmed_pod_id}.{safe_uuid}"
+ safe_pod_id = f"{trimmed_pod_id}-{safe_uuid}"
Review comment:
This feels like the right solution to me. Could you update the PR to use
this?
A comment explaining why the various cleanups are needed would also be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
