josh-fell commented on a change in pull request #18278: URL: https://github.com/apache/airflow/pull/18278#discussion_r716308040
########## File path: airflow/providers/sqlite/example_dags/example_sqlite.py ########## @@ -55,6 +54,7 @@ # [END howto_operator_sqlite] [email protected](task_id="insert_sqlite_task") def insert_sqlite_hook(): sqlite_hook = SqliteHook("sqlite_default") Review comment: Agreed with the `default_args` suggestion, sounds good. Although, are we OK with having the "create_table_sqlite_external_file" task fail when this DAG is run? It requires an external SQL file to execute. I can easily get the other 3 tasks to succeed though. Perhaps we could remove the "create_table_sqlite_external_file" task, add a comment in the DAG about executing SQL stored in an external file, and update the corresponding doc too if we want this DAG to complete successfully in its entirety. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
