potiuk commented on a change in pull request #5200: [AIRFLOW-4401] Use managers
for Queue synchronization
URL: https://github.com/apache/airflow/pull/5200#discussion_r279615048
##########
File path: airflow/contrib/executors/kubernetes_executor.py
##########
@@ -769,3 +793,7 @@ def _change_state(self, key, state, pod_id):
def end(self):
self.log.info('Shutting down Kubernetes executor')
self.task_queue.join()
Review comment:
I think here we had a problem here before because task_queue.join() was used
but nowhere task_queue.task_done() was executed. This could have resulted in
hangs when shutting down Kubernetes Executor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
