jedcunningham commented on a change in pull request #18542:
URL: https://github.com/apache/airflow/pull/18542#discussion_r717011324
##########
File path: chart/values.schema.json
##########
@@ -142,11 +142,35 @@
"default": ""
},
"hosts": {
- "description": "The hostnames for the web
Ingress.",
+ "description": "The hosts configuration for the
web Ingress.",
"type": "array",
"default": [],
"items": {
- "type": "string"
+ "type": "object",
+ "properties": {
Review comment:
```suggestion
"additionalProperties": false,
"properties": {
```
##########
File path: chart/values.schema.json
##########
@@ -142,11 +142,35 @@
"default": ""
},
"hosts": {
- "description": "The hostnames for the web
Ingress.",
+ "description": "The hosts configuration for the
web Ingress.",
"type": "array",
"default": [],
"items": {
- "type": "string"
+ "type": "object",
+ "properties": {
+ "name": {
+ "description": "The hostname for the
web Ingress.",
+ "type": "string",
+ "default": ""
+ },
+ "tls": {
+ "description": "Configuration for web
Ingress TLS.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Enable TLS
termination for the web Ingress.",
+ "type": "boolean",
+ "default": false
+ },
+ "secretName": {
+ "description": "The name of a
pre-created Secret containing a TLS private key and certificate.",
+ "type": "string",
+ "default": ""
+ }
+ }
+ }
+ }
Review comment:
Probably want to ensure we at least get a host, no?
```suggestion
},
"required": ["host"],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
