r-richmond opened a new pull request #5206: AIRFLOW-4434 fix support for impala 
in hive hook
URL: https://github.com/apache/airflow/pull/5206
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira 
#4434](https://issues.apache.org/jira/browse/AIRFLOW-4434) issues and 
references them in the PR title.
   
   ### Description
   
   -  [X] Here are some details about my PR, including screenshots of any UI 
changes:
   
   I've introduced this PR to allow users the option to avoid running set 
variables for the hive hook. My initial motivation was to un-break impala 
support (broken via https://github.com/apache/airflow/pull/3405 ) but decided 
to write the PR in this way so that users could disable the set statements for 
hive (or other systems accessed through the hive hook) as well.
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Given the nature of the fix I don't think they're needed but perhaps the 
maintainers feel differently.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [X] Passes `flake8`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to