[ 
https://issues.apache.org/jira/browse/AIRFLOW-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830213#comment-16830213
 ] 

ASF GitHub Bot commented on AIRFLOW-4436:
-----------------------------------------

ashb commented on pull request #5209: [AIRFLOW-4436] Don't build the same 
docker image twice in tests
URL: https://github.com/apache/airflow/pull/5209
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-4436
   
   ### Description
   
   - [x] Save 5 minutes of test time for the Kube job.
   
     **Before**: 30min 11sec
   
     **After**: 24 min 14 sec
   
   ### Tests
   
   - [x] None
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Don't re-build docker images twice for Kube tests
> -------------------------------------------------
>
>                 Key: AIRFLOW-4436
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4436
>             Project: Apache Airflow
>          Issue Type: Sub-task
>            Reporter: Ash Berlin-Taylor
>            Priority: Major
>
> We re-build the same docker image twice in our Kube test suite (once for each 
> of the git deploy and PV modes) but the image is the same. This is pointless 
> and slow (doesn't get cached cos the timestamp of the files changes)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to