khalidmammadov opened a new pull request #18685:
URL: https://github.com/apache/airflow/pull/18685


   This is a simple change to rename variables to be consistent with code logic 
and with the "story-line"
   
   So, basically code calls `create_dagrun()` to create a dag run... and 
assigns it to a variable called "trigger". Although it's "ok" to name that way, 
it's much more readable to make it clear/explicit and call returned object a 
"dagrun" as it's an instance of it.
   Also reading it in English trigger conveys a bit different meaning i.e. 
original purpose of the action `airflow dags trigger ...` and so not best name 
for the returned object and subsequent collection of objects i.e. triggers[]
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to