ashb commented on a change in pull request #4743: [AIRFLOW-3871] render
Operators template fields recursively
URL: https://github.com/apache/airflow/pull/4743#discussion_r279770788
##########
File path: airflow/models/baseoperator.py
##########
@@ -644,9 +648,23 @@ def render_template_from_field(self, attr, content,
context, jinja_env):
k: rt("{}[{}]".format(attr, k), v, context)
for k, v in list(content.items())}
else:
- result = content
+ result = self._render_nested_template_fields(content, context)
return result
+ def _render_nested_template_fields(self, content, context):
+ if id(content) not in self._rendered_template_object_ids:
+ self._rendered_template_object_ids.add(id(content))
+ try:
+ nested_template_fields = content.template_fields
+ except AttributeError:
+ # content has no inner template fields
+ return content
+
+ for field in nested_template_fields:
+ rendered = self.render_template(field, getattr(content,
field), context)
Review comment:
```suggestion
rendered = self.render_template(field, getattr(content,
field), context, seen_oids)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
