dstandish opened a new pull request #18692: URL: https://github.com/apache/airflow/pull/18692
Some notes Did not update all tests cus i just want to put it out there for thoughts first. I think that ultimately we need to pull some of this logic up into base secrets backend. E.g. perhaps in base secrets backend we can accept parameter `conn_as_kwargs` to let it know whether to expect kwargs or URI. and i say kwargs instead of json because some things like vault and aws secrets manager are already key value stores that may return dict not json string. And i think some more logic is commonly duplicated e.g. building out the paths given a secret id. And if we want to standardize how airflow conns should be json serialized, we may need to add an abstraction `get_secret` which just gets the raw value --- so that the parsing can be fully handled by the base class. Also: Why parameterize with `connection_as_kwargs` instead of subclass? It doesn't make sense to have a *Json version of every secrets backend, especially because the json part of it only applies to connections and not config or variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
