This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 0355d3f Fix eager-upgrade builds for Airflow main. (#18719)
0355d3f is described below
commit 0355d3f5e1c5dbb5ef85edddbc82e958ecbb9772
Author: Jarek Potiuk <[email protected]>
AuthorDate: Tue Oct 5 02:58:38 2021 +0200
Fix eager-upgrade builds for Airflow main. (#18719)
For 5 days now Airflow's main did not build with eager upgrade
for Python 3.7+. Unfortunately PIP did not give us enough clues
of what happend, so we had to investigated it and found out
that google-ads 14.0.1 bumped google-python-core-api dependency
to above 2.0.0 and we have limits in place as some other libraries
are not compatible with it.
See:
https://github.com/apache/airflow/issues/18705#issuecomment-933746150
Fix is to limit google-ads.
---
setup.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index b8fc09b..8c04a23 100644
--- a/setup.py
+++ b/setup.py
@@ -280,7 +280,10 @@ flask_appbuilder_authlib = [
]
google = [
'PyOpenSSL',
- 'google-ads>=12.0.0',
+ # The Google Ads 14.0.1 breaks PIP and eager upgrade as it requires
+ # google-api-core>=2.0.0 which cannot be used yet (see below comment)
+ # and https://github.com/apache/airflow/issues/18705#issuecomment-933746150
+ 'google-ads>=12.0.0,<14.0.1',
# Maintainers, please do not require google-api-core>=2.x.x
# Until this issue is closed
# https://github.com/googleapis/google-cloud-python/issues/10566
