ephraimbuddy commented on a change in pull request #18718:
URL: https://github.com/apache/airflow/pull/18718#discussion_r722007122
##########
File path: airflow/operators/sql.py
##########
@@ -34,18 +34,26 @@ class BaseSQLOperator(BaseOperator):
You can custom the behavior by overriding the .get_db_hook() method.
"""
- def __init__(self, *, conn_id: Optional[str] = None, database:
Optional[str] = None, **kwargs):
+ def __init__(
+ self,
+ *,
+ conn_id: Optional[str] = None,
+ database: Optional[str] = None,
+ hook_params: Dict = {},
Review comment:
This is wrong, see the important warning on this page:
https://docs.python.org/3/tutorial/controlflow.html#default-argument-values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
