jedcunningham commented on a change in pull request #18747:
URL: https://github.com/apache/airflow/pull/18747#discussion_r722316421
##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -307,22 +306,21 @@ runtime user id which is unknown at the time of building
the image.
| ``AIRFLOW_UID`` | UID of the user to run Airflow containers
as. | ``50000`` |
| | Override if you want to use use non-default
Airflow | |
| | UID (for example when you map folders from
host, | |
-| | it should be set to result of ``id -u``
call. If | |
-| | you change it from default 50000, you must
set | |
-| | ``AIRFLOW_GID`` to ``0``. When it is
changed, | |
-| | a 2nd user with the UID specified is
dynamically | |
+| | it should be set to result of ``id -u``
call. | |
+| | When it is changed, s user with the UID is
| |
Review comment:
```suggestion
| | When it is changed, a user with the UID
is | |
```
##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -307,22 +306,21 @@ runtime user id which is unknown at the time of building
the image.
| ``AIRFLOW_UID`` | UID of the user to run Airflow containers
as. | ``50000`` |
| | Override if you want to use use non-default
Airflow | |
| | UID (for example when you map folders from
host, | |
-| | it should be set to result of ``id -u``
call. If | |
-| | you change it from default 50000, you must
set | |
-| | ``AIRFLOW_GID`` to ``0``. When it is
changed, | |
-| | a 2nd user with the UID specified is
dynamically | |
+| | it should be set to result of ``id -u``
call. | |
+| | When it is changed, s user with the UID is
| |
| | created with ``default`` name inside the
container | |
| | and home of the use is set to
``/airflow/home/`` | |
| | in order to share Python libraries
installed there. | |
| | This is in order to achieve the OpenShift
| |
| | compatibility. See more in the
| |
| | :ref:`Arbitrary Docker User
<arbitrary-docker-user>`| |
+--------------------------------+-----------------------------------------------------+--------------------------+
-| ``AIRFLOW_GID`` | Group ID in Airflow containers. It
overrides the | ``50000`` |
-| | GID of the user. It is ``50000`` by default
but if | |
-| | you want to use different UID than default
it must | |
-| | be set to ``0``.
| |
-+--------------------------------+-----------------------------------------------------+--------------------------+
+
+.. note::
+
+ Before Airflow 2.2, the Docker Compose also had ``AIRFLOW_GID`` parameter,
but it had not provided any additional
Review comment:
```suggestion
Before Airflow 2.2, the Docker Compose also had ``AIRFLOW_GID``
parameter, but it did not provide any additional
```
##########
File path: docs/docker-stack/build-arg-ref.rst
##########
@@ -67,6 +62,11 @@ Those are the most common arguments that you use when you
want to build a custom
| |
| Auto-detected if empty. |
+------------------------------------------+------------------------------------------+---------------------------------------------+
+.. note::
+
+ Before Airflow 2.2, the image also had ``AIRFLOW_GID`` parameter, but it
had not provided any additional
Review comment:
```suggestion
Before Airflow 2.2, the image also had ``AIRFLOW_GID`` parameter, but it
did not provide any additional
```
##########
File path: docs/docker-stack/entrypoint.rst
##########
@@ -50,10 +50,10 @@ those formats (See `Docker Run reference
<https://docs.docker.com/engine/referen
In case of Docker Compose environment it can be changed via ``user:`` entry in
the ``docker-compose.yaml``.
See `Docker compose reference
<https://docs.docker.com/compose/compose-file/compose-file-v3/#domainname-hostname-ipc-mac_address-privileged-read_only-shm_size-stdin_open-tty-user-working_dir>`_
for details. In our Quickstart Guide using Docker-Compose, the UID and GID can
be passed via
Review comment:
```suggestion
for details. In our Quickstart Guide using Docker-Compose, the UID can be
passed via the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
