jarfgit commented on a change in pull request #17145:
URL: https://github.com/apache/airflow/pull/17145#discussion_r722435325



##########
File path: airflow/providers/amazon/aws/operators/s3_list.py
##########
@@ -72,8 +72,8 @@ def __init__(
         self,
         *,
         bucket: str,
-        prefix: str = '',
-        delimiter: str = '',
+        prefix: str,
+        delimiter: str,

Review comment:
       Actually no. I copied this code for the S3ListPrefixes operator - where 
you'd presumably want these to be explicit values, but that doesn't necessarily 
apply to S3List. Let me revert this and push it up. Good catch :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to