potiuk commented on a change in pull request #18699:
URL: https://github.com/apache/airflow/pull/18699#discussion_r722486335
##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -622,7 +622,7 @@ def start_template_dataflow(
dataflow_template: str,
project_id: str,
append_job_name: bool = True,
- on_new_job_id_callback: Optional[Callable[[str], None]] = None,
+ on_new_job_callback: Optional[Callable[[dict], None]] = None,
Review comment:
How about adding new callback instead? It feels a bit risky, and it
does not hurt to have two parameters (we can deprecate the old one and raise
deprecation warning)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
