zachliu commented on pull request #18733:
URL: https://github.com/apache/airflow/pull/18733#issuecomment-934735657
> > > @zachliu i'm double-checking the issue #15000. So would it be better
to check `stopCode: TaskFailedToStart` rather than existence of the log stream
of the task in order to handle the case properly? Because in #17626 you said
that log stream is a kinda flag when ECS fails to provision tasks.
> >
> >
> > well ideally it would be better. but since that thing is hiding deep in
the json response, the code may not look so good joy_cat
> > ```
> > response.get('tasks')[0].get('stoppedReason')
> > response.get('tasks')[0].get('stopCode')
> > ```
>
> What if cloudwatch logs are disabled in the operator (group/streams are
not provided), then the edge case would not be caught since we don't know what
log stream to check, right? Then the only way is to really parse the json.
i was just joking around AWS's response structure :grin:
yeah parsing the json is the ultimate solution :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
