potiuk commented on pull request #18752: URL: https://github.com/apache/airflow/pull/18752#issuecomment-936485659
> > Would it be possible to add a test for this? > > I struggled to think of a test that can add any value here while mocking all interactions with the underlying `smbprotocol` library. Mocking `open` and the `open_file` method to ensure they are both opened using binary and/or ensuring that `copyfileobj` only takes file-like objects whose read and write methods expect binary strings seems like the only options, but I didn't that having that as a test helped. My thughts exactly. For me that's one of those fixes for which the unit tests bring no value, just add complexitty really. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
