potiuk edited a comment on issue #18717:
URL: https://github.com/apache/airflow/issues/18717#issuecomment-937718818


   > So what actually we can do about it? Somehow implement autorefresh when 
new DAG is added or just refresh the list with some time interval? I don't 
fully get your message @potiuk (please review it)
   
   Just to clarify - I think (and I think @BasPH  thinks the same) this 
"list-only refreshing" is only going to be useful if we implement it similarly 
to http://airflow.apache.org/docs/apache-airflow/stable/ui.html#graph-view with 
auto-refresh. Otherwise it's fine for the users to "Refresh" using Browser's 
built in refresh button.
   
   There are two cases:
   
   1) When users want to manually refresh the list - > this is perfectly fine 
to hit the browser "Refresh" button. There will be a bit flickering when the 
whole page reloads, but this is perfectly fine - when someone hits refresh 
button, this is natural and expected. And the way caching works in the browser 
refreshing the "whole page" will not be much slower than "just refresh the 
list" - the time between the user clicks the "refresh" button and gets the page 
rendered will be about the same whether you use refresh browser button or 
"mini-refresh" list button - simply because most of the time will be reading 
the content of the list and rendering the content of it. And Hitting "refresh" 
in browser has an additional advantage in this case, because you know (browser 
tells you) when the refresh finished (it shows progress bar and visually 
indicates refresh is in progress) . So there is little value to it. 
   
   If you would like to do a "list only" refresh button, you have to make it a 
bit more complex than what refresh of browser is doing - you also need to 
include some kind of progress information - i.e. indicate to the user that 
refreshing is in-progress and that it finished. You need to replace the DOM 
Content in the way that flickering is minimized (likely with atomic replacement 
of the whole new list content in one go). And once you did  it, that it's very 
close to being able to run auto-refresh like we have in 
http://airflow.apache.org/docs/apache-airflow/stable/ui.html#graph-view 
   
   And this leads us to second case 
   
   2) Automatically refresh the list with "auto-refresh" feature like we have 
in graph view. This one has MUCH bigger value, as this means you have all the 
content fresh without your action. 
   
   So my point is  - if youd add just "refresh" button the value added is 
minimal, but the value is much bigger if you also make "auto-refresh" working 
at the same time for that page.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to