JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r724155832
##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -134,12 +138,17 @@ def client(self):
return session.client(service_name="secretsmanager", **self.kwargs)
- def _format_uri_with_extra(self, secret, conn_string):
+ @staticmethod
+ def _format_uri_with_extra(secret, conn_string):
try:
extra_dict = secret['extra']
except KeyError:
return conn_string
- conn_string = f"{conn_string}?{urlencode(extra_dict)}"
+
+ extra = ast.literal_eval(
+ extra_dict
+ ) # json.loads doesn't work because you can have unquoted booleans
values
+ conn_string = f"{conn_string}?{urlencode(extra)}"
Review comment:
From boto3
https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/secrets/secrets_manager.py#L231-L236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
