uranusjr commented on a change in pull request #18439:
URL: https://github.com/apache/airflow/pull/18439#discussion_r724683211
##########
File path: airflow/utils/db.py
##########
@@ -626,27 +629,85 @@ def check_migrations(timeout):
:param timeout: Timeout for the migration in seconds
:return: None
"""
- from alembic.runtime.migration import MigrationContext
+ for ticker in range(timeout):
+ source_heads = get_source_heads()
+ db_heads = get_db_heads()
+ if source_heads == db_heads:
+ return
+ time.sleep(1)
+ log.info('Waiting for migrations... %s second(s)', ticker)
+ raise TimeoutError(
+ f"There are still unapplied migrations after {timeout} seconds. "
+ f"Migration Head(s) in DB: {db_heads} | Migration Head(s) in Source
Code: {source_heads}"
+ )
+
+
+def get_source_heads() -> Set:
Review comment:
If you don't need to annotate item types, the built-in `set` is enough.
But this is fine as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
