anaynayak commented on pull request #18807: URL: https://github.com/apache/airflow/pull/18807#issuecomment-939226870
@uranusjr thank you for reviewing the PR. Few points from the summary which I wanted to clarify: 1. Removal of `self.full_url` from the class hopefully doesn't require a change on [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md) 2. Usage of `@cached_property` for the hook. Noticed this in other places. Can add it here for consistency. 3. Haven't done a similar change across other S3 sensors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
