potiuk commented on a change in pull request #17974:
URL: https://github.com/apache/airflow/pull/17974#discussion_r725644559
##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -282,3 +282,25 @@ def bulk_load_custom(
cursor.close()
conn.commit()
+
Review comment:
I think this has nothing to dow with before/after statement? Could you
please separate it out ?
##########
File path: airflow/hooks/dbapi.py
##########
@@ -260,7 +260,15 @@ def get_cursor(self):
return self.get_conn().cursor()
@staticmethod
- def _generate_insert_sql(table, values, target_fields, replace, **kwargs):
+ def _generate_insert_sql(
+ table,
+ values,
+ target_fields,
+ replace,
+ *args,
+ before_statement: Optional[str] = None,
Review comment:
We have a potential backwards/forwards compatibility problem here.
Similarly as in #17329
https://github.com/apache/airflow/pull/17329#pullrequestreview-775561528 we
have to add protection for future versions of providers using the before/after
statementts to start depending on Airflow 2.3 version (or handle backwards
compatibility). Because if new providers will use those, they will not work
with already released versions of Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
