danarwix opened a new pull request #18881: URL: https://github.com/apache/airflow/pull/18881
TLDR; refactoring to give a given->when->than testing structure https://martinfowler.com/bliki/GivenWhenThen.html When working on adding the `verify` parameter on https://github.com/apache/airflow/pull/18791, i have noticed that in each test i see the following: 1. `assert mock_connect.return_value == conn` -> that line did not effect the test. inherently, that test ensured that the `MagicMock` equals the `MagicMock` which did not contribute anything to the test itself 2. mocking the connection -> ```python mock_get_connection.return_value = Connection( login='login', password='password', host='host', schema='hive' ) ``` is constantly repeated so i extracted it to a function called: `get_get_connection_return_value(mock_get_connection, extra=None, password=None)` 3. asserting the parameters in which the connection is called was also extracted to a function called: `assert_connection_called_with(mock_connect, auth=None, verify=True)` <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
