potiuk commented on a change in pull request #18902:
URL: https://github.com/apache/airflow/pull/18902#discussion_r726903363



##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -929,7 +929,7 @@ function initialization::ga_env() {
 function initialization::ver() {
   # convert SemVer number to comparable string (strips pre-release version)
   # shellcheck disable=SC2086,SC2183
-  printf "%04d%04d%04d%.0s" ${1//[.-]/ }
+  printf "%03d%03d%03d%.0s" ${1//[.-]/}

Review comment:
       No. We don't. But it does not hurt (and we need to handle leading zeros 
anyway if the major version actually is `0`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to