mik-laj commented on a change in pull request #18926:
URL: https://github.com/apache/airflow/pull/18926#discussion_r727578230
##########
File path: airflow/cli/cli_parser.py
##########
@@ -73,6 +73,12 @@ def _check_value(self, action, value):
"To do it, run: pip install
'apache-airflow[cncf.kubernetes]'"
)
raise ArgumentError(action, message)
+ if action.dest == 'subcommand' and value == 'triggerer':
+ try:
Review comment:
Why are you doing method detection instead of just checking interpreter
versions (``sys.version``)? To do it, you can use these constants:
https://github.com/apache/airflow/blob/95279bdb8989fc0e433799792dab2ed38373e1f8/airflow/__init__.py#L50-L53
This will make it easier for us to clean up our code when we drop legacy
support by simply checking the usages
> Explicit is better than implicit.
[PEP-20](https://www.python.org/dev/peps/pep-0020/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
