uranusjr commented on a change in pull request #18927:
URL: https://github.com/apache/airflow/pull/18927#discussion_r727590968



##########
File path: airflow/providers/google/cloud/transfers/cassandra_to_gcs.py
##########
@@ -110,6 +117,7 @@ def __init__(
         google_cloud_storage_conn_id: Optional[str] = None,
         delegate_to: Optional[str] = None,
         impersonation_chain: Optional[Union[str, Sequence[str]]] = None,
+        query_timeout: Optional[Union[float, NotSetType]] = NOT_SET,

Review comment:
       ```suggestion
           query_timeout: Union[float, None, NotSetType] = NOT_SET,
   ```

##########
File path: airflow/providers/google/cloud/transfers/cassandra_to_gcs.py
##########
@@ -84,6 +87,10 @@ class CassandraToGCSOperator(BaseOperator):
         Service Account Token Creator IAM role to the directly preceding 
identity, with first
         account from the list granting this role to the originating account 
(templated).
     :type impersonation_chain: Union[str, Sequence[str]]
+    :param query_timeout: (Optional) The floating-point timeout used to 
execute the Cassandra query.
+        If not set, the timeout value will be set in Session.execute() by 
Cassandra driver.
+        If set to None, there is no timeout.
+    :type query_timeout: Union[float, NotSetType]

Review comment:
       Don't need to mention `NotSetType` here. Documentation is for the user, 
so you only need to mention the values they need to set.
   
   ```suggestion
       :type query_timeout: float | None
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to