zbstof edited a comment on pull request #18938: URL: https://github.com/apache/airflow/pull/18938#issuecomment-942236636
Turns out there's already a test that dict keys are not rendered, added by @BasPH , but I think it was codifying existing behaviour, not enforcing a contract. I fixed that test Please clarify if you want me to add more test cases? > maybe there was a reason it was implemented like that ? Given how dicts are just fancy list of 2-tuples, and we already handle explicit lists and tuples, I don't see why we shouldn't handle dictionary keys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
