gigatexal commented on pull request #18800:
URL: https://github.com/apache/airflow/pull/18800#issuecomment-943257963
> CC @dstandish to bring some threads together.
>
> @dstandish brought up a very valid point about Secrets Backend use here
and perhaps the best approach might be moving to `.get(...) or None` given how
the Salesforce API determines authentication + how users could create their
connection to Salesforce in Airflow - UI or otherwise.
>
> @gigatexal WDYT?
That works for me but -- and here's where my python ignorance shines -- I
thought `dict.get(k)` would return `None` if `k` did not exist. The whole point
of this was to get around the exception of k not existing.
```
get(key, default=None, /) method of builtins.dict instance
Return the value for key if key is in the dictionary, else default.
```
Which the above is fine for the `extras` dict but the issues -- as I see it
-- is with the explicitly set `None` in the tests and my experience in testing
being still very rookie I am not sure what to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
