zigius commented on a change in pull request #19030:
URL: https://github.com/apache/airflow/pull/19030#discussion_r730368762
##########
File path: airflow/providers/amazon/aws/operators/ecs.py
##########
@@ -120,9 +120,10 @@ def run(self) -> None:
logs_to_skip += 1
time.sleep(self.fetch_interval.total_seconds())
- def _get_log_events(self, skip: int = 0) -> Generator:
+ def _get_log_events(self, start_from_head=True, skip: int = 0) ->
Generator:
Review comment:
linting
##########
File path: airflow/providers/amazon/aws/operators/ecs.py
##########
@@ -120,9 +120,10 @@ def run(self) -> None:
logs_to_skip += 1
time.sleep(self.fetch_interval.total_seconds())
- def _get_log_events(self, skip: int = 0) -> Generator:
+ def _get_log_events(self, start_from_head=True, skip: int = 0) ->
Generator:
Review comment:
also, add typing to `start_from_head`? and change the order of the
params to make sure you preserve backwards compatibility?
`def _get_log_events(self, skip: int = 0, start_from_head: bool = True) ->
Generator:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
