jedcunningham opened a new pull request #19034:
URL: https://github.com/apache/airflow/pull/19034


   This is partially done, I'm simply soliciting feedback.
   
   Allow Param to support a default value of ``None``.
   
   Also refactors Param to not store the resolved value into it's ``default``.
   
   At least to me, there wasn't a clean separation of the param defined in the 
DAG and the conf value from the dagrun, as the latter overrides the former. e.g:
   
   ```
   p = Param(default="default", type="string")
   p.resolve()  # "default"
   p.resolve(value="hello")  # "hello"
   p.resolve()  # "hello"
   p.default  # "hello"
   ```
   
   ParamDict ended up being a combo of the Params from the DAG with all the 
defaults set to the dagruns conf values.
   
   Alternatively, I think all references to `default` should be changed to 
`value`?
   
   closes: #18909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to