khalidmammadov commented on pull request #18590: URL: https://github.com/apache/airflow/pull/18590#issuecomment-945666104
> Since Marshmallow is already a hard dependency, I feel we should just use it for validation instead of hand-rolling logic. Just tried to use UserCollectionItemSchema for validation and fails as `users_export` function removes underscores from first_name and last_name during export. This causes mismatch with UserCollectionItemSchema during load. No sure why this is done: https://github.com/apache/airflow/blob/86a2a19ad2bdc87a9ad14bb7fde9313b2d7489bb/airflow/cli/commands/user_command.py#L135-L148 Removing that will create incompatibility issue with import users feature. Perhaps we need a separate issue/goal for converting these type of codes to use schemas and discuss braking changes accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
