ashb commented on issue #5224: [AIRFLOW-4146] Fix CgroupTaskRunner errors URL: https://github.com/apache/airflow/pull/5224#issuecomment-488599208 Even an a basic test checking for import errors would be better than nothing yes! If you can add something like that then we can merge this PR. Yeah looking at how the runner is currently implemented it would be a right pain to mock. If you are up for it (in another PR) porting to cgroupspy would make it better to test. Alternatively/additionally an extra "Job" in Travis (since that runs on Linux outside of docker) may be worth it. Lot more work so understand if you don't have time to do that
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
