ashb edited a comment on issue #19058:
URL: https://github.com/apache/airflow/issues/19058#issuecomment-947646997


   
   > 
   > But considering how poor the performance was when we added a new field on 
TaskInstance, this might not be a good idea since we need to backfill 
`log_filename` values to all existing TI values. A workaround is to add this to 
*DagRun* instead, but still god only knows if the data migration performance 
could be acceptable. Another thing to benchmark on, I guess.
   
   The poor performance was caused by changing the PK, not just adding a column.
   
   If we add a nullable column it should be near O(1).
   
   Oh, backfilling too. Yeah that would be possibly expensive. We could 
backfill only on demand? i.e. on model first access of it doesn't have it set 
it will render andset it to the db?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to