doddsiedodds commented on a change in pull request #19102:
URL: https://github.com/apache/airflow/pull/19102#discussion_r735344361
##########
File path: tests/dag_processing/test_processor.py
##########
@@ -155,7 +154,6 @@ def
test_dag_file_processor_sla_miss_callback_invalid_sla(self, create_dummy_dag
dag_file_processor = DagFileProcessor(dag_ids=[], log=mock.MagicMock())
dag_file_processor.manage_slas(dag=dag, session=session)
- sla_callback.assert_not_called()
Review comment:
It shouldn't have been, I originally started by adding the stats
increment counter later in the sla management code and so I had switched this
for an `assert_called_once`, Must have just not reverted this line. Will
reinstate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
