uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r737501347
########## File path: tests/providers/amazon/aws/utils/test_emailer.py ########## @@ -16,27 +16,32 @@ # specific language governing permissions and limitations # under the License. # - -from unittest import mock +from unittest import TestCase, mock from airflow.providers.amazon.aws.utils.emailer import send_email [email protected]("airflow.providers.amazon.aws.utils.emailer.SESHook") -def test_send_email(mock_hook): - send_email( - to="[email protected]", - subject="subject", - html_content="content", - ) - mock_hook.return_value.send_email.assert_called_once_with( - mail_from=None, - to="[email protected]", - subject="subject", - html_content="content", - bcc=None, - cc=None, - files=None, - mime_charset="utf-8", - mime_subtype="mixed", - ) +class TestSendEmailSes(TestCase): + def setUp(self): + pass Review comment: Why is this class needed if there's no setup and teardown needed whatsoever? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
