[
https://issues.apache.org/jira/browse/AIRFLOW-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832857#comment-16832857
]
ASF GitHub Bot commented on AIRFLOW-4455:
-----------------------------------------
JCoder01 commented on pull request #5234: [AIRFLOW-4455] dag_details broken for
subdags in RBAC UI
URL: https://github.com/apache/airflow/pull/5234
Make sure you have checked _all_ steps below.
### Jira
- [x ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4455
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Changes fileloc for subdags to the fileloc of the parent dag to enable
dag_orm to load find the subdag
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
adds assert to test_sync_to_db to confirm subdag.fileloc == dag.fileloc
adds new test test_views to confirm the view works for subdags.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ x ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> dag_details broken for subdags in RBAC UI
> -----------------------------------------
>
> Key: AIRFLOW-4455
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4455
> Project: Apache Airflow
> Issue Type: Bug
> Components: webapp
> Affects Versions: 1.10.3
> Reporter: James Coder
> Priority: Major
> Labels: regression
> Fix For: 1.10.4
>
>
> With the release of 1.10.3 dagbag was removed from the dag_details view. This
> appears to have broken the dag details view for subdags. [line
> 1484|https://github.com/apache/airflow/blob/cec54947d7cf0489284995a6a899b9b94620e301/airflow/models/dag.py#L1484]
> in models/Dag.py now uses the dag fileloc to get the dag, however for a
> subdag, the file loc may not contain the dag if the dag is defined in a
> function as recommended.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
