potiuk commented on a change in pull request #19237:
URL: https://github.com/apache/airflow/pull/19237#discussion_r737875169
##########
File path:
airflow/providers/amazon/aws/example_dags/example_dms_full_load_task.py
##########
@@ -50,20 +49,14 @@
with DAG(
dag_id='dms_full_load_task_run_dag',
- default_args={
- 'owner': 'airflow',
- 'depends_on_past': False,
- 'email': ['[email protected]'],
- 'email_on_failure': False,
- 'email_on_retry': False,
- },
dagrun_timeout=timedelta(hours=2),
- start_date=days_ago(2),
+ start_date=datetime(2021, 1, 1),
schedule_interval='0 3 * * *',
+ catchup=False,
Review comment:
Dynamic dates were wrong. They are not realistic examples. None uses
'days_ago' so changing to static values is better. But i kinda agree that
making ALL examples with catch-up=False does not hurt.
I'd even go as far as an automated pre-commits check if all examples have
catch-up=False set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
