potiuk commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r737939320
##########
File path: Dockerfile
##########
@@ -382,12 +392,8 @@ ARG AIRFLOW_HOME
# Having the variable in final image allows to disable providers manager
warnings when
# production image is prepared from sources rather than from package
ARG AIRFLOW_INSTALLATION_METHOD="apache-airflow"
-ARG BUILD_ID
-ARG COMMIT_SHA
ARG AIRFLOW_IMAGE_REPOSITORY
ARG AIRFLOW_IMAGE_DATE_CREATED
-# By default PIP will install everything in ~/.local
-ARG PIP_USER="true"
Review comment:
Technically it's not. It's a different setting of PIP by default. but
airflow and any `pip` commands will remain working as before:
`pip install package1` - > will install package1 in airflow installation
`pip update package2` -> will upgrade package2 in airflow installation
and so on.
I seet this as technical 'internal' of how the image is build. People when
using the image are interested in how `airflow ` works, not what `pip
parameters` are. those are secondary and as long as existing ways of extending
and customizing the image are unchnaged, this is technically backwards
compatible.
I also described it in "Building the image" documentation (similarly as
before we described similar changes in previous versions of the image. Not as
"braeking change" but as "change".
Actually we even had bigger changes in the past. 2.0.0 did not have PIP_USER
flag set and we required `--user` flag to be set when extending the image
(it's also documented there).
This change is far more "transparent" and 'backwards compatible".
The same you could say that adding `LD_PRELOAD=` is not backwards compatible
and we would not be able to release such fixes with new airflow images if we
care about every single environment variable that modifies the behaviour of any
other third-party tools - or when we upgrade `pip` (there were far more
incompatible changes in different PIP versions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
