uranusjr commented on a change in pull request #19257:
URL: https://github.com/apache/airflow/pull/19257#discussion_r738059792
##########
File path: airflow/models/dag.py
##########
@@ -368,8 +369,11 @@ def __init__(
DeprecationWarning,
stacklevel=2,
)
-
- validate_key(dag_id)
+
+ if not is_ascii(dag_id):
+ # slugify dag id
+ dag_id = slugify(dag_id, lowercase=False)
Review comment:
I wonder if we should only slugify the *non-ASCII parts of the ID*
instead of *the entire ID if anything is non-ASCII*, so `dag_你好_cześć` becomes
`dag_ni-hao_czesc` instead of `dag-ni-hao-czesc`. But maybe people don't
actually care and I'm just thinking too hard on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
