o-nikolas commented on a change in pull request #19022:
URL: https://github.com/apache/airflow/pull/19022#discussion_r738661868
##########
File path: airflow/config_templates/airflow_local_settings.py
##########
@@ -194,13 +193,17 @@
DEFAULT_LOGGING_CONFIG['handlers'].update(S3_REMOTE_HANDLERS)
elif REMOTE_BASE_LOG_FOLDER.startswith('cloudwatch://'):
+ create_log_group = conf.getboolean('logging',
'CREATE_CLOUDWATCH_LOG_GROUP', fallback=True)
+ create_log_stream = conf.getboolean('logging',
'CREATE_CLOUDWATCH_LOG_STREAM', fallback=True)
Review comment:
I don't think we should allow this setting to be configured. Setting
stream creation to anything but True will catastrophically break cloudwatch
logging.
In cloudwatch Log Groups are like folders and streams are like files. It is
possible to pre-create the log group "folder" but the stream log "files" are
named on the fly after the task instances themselves (just like the default
Airflow local filesystem logging). There's no (reasonable) way you could
pre-create those stream names and thus watchtower, if not allowed to create the
streams itself, will fail to log any task logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
