jedcunningham commented on a change in pull request #17934:
URL: https://github.com/apache/airflow/pull/17934#discussion_r710187980
##########
File path: chart/templates/_helpers.yaml
##########
@@ -146,9 +146,13 @@ If release name contains chart name it will be used as a
full name.
securityContext:
runAsUser: {{ .Values.dags.gitSync.uid }}
env:
- {{- if .Values.dags.gitSync.sshKeySecret }}
+ {{- if or .Values.dags.gitSync.sshKeySecret
.Values.dags.gitSync.sshKeyCustomFile }}
- name: GIT_SSH_KEY_FILE
+ {{- if .Values.dags.gitSync.sshKeyCustomFile}}
+ value: {{ .Values.dags.gitSync.sshKeyCustomFile | quote }}
+ {{- else }}
value: "/etc/git-secret/ssh"
+ {{- end }}
Review comment:
```suggestion
value: {{ .Values.dags.gitSync.sshKeyCustomFile | default
"/etc/git-secret/ssh" | quote }}
```
Just noticed this can also be simplified.
##########
File path: docs/helm-chart/manage-dags-files.rst
##########
@@ -177,6 +177,38 @@ In this example, you will create a yaml file called
``override-values.yaml`` to
Don't forget to copy in your private key base64 string.
+Using SSH Key from Hashicorp Vault instead of Secret
+----------------------------------------------------
Review comment:
Maybe move this to the end of the file, and change it to a subsubsection
(i.e. use "^" instead of "-").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
