dstandish commented on a change in pull request #19257:
URL: https://github.com/apache/airflow/pull/19257#discussion_r739611371
##########
File path: airflow/models/dag.py
##########
@@ -368,8 +369,11 @@ def __init__(
DeprecationWarning,
stacklevel=2,
)
-
- validate_key(dag_id)
+
+ if not is_ascii(dag_id):
+ # slugify dag id
+ dag_id = slugify(dag_id, lowercase=False)
Review comment:
Is it true that the plan here is to allow your dag code to have one
`dag_id` defined with non-ascii characters, but in the metastore, and therefore
in the UI, you would have a _different_ dag id, with the value ascii-ified?
this seems undesirable to me. seems we should either remove the ascii
requirement or do nothing, so that code always agrees with metastore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
