potiuk edited a comment on issue #5238: [AIRFLOW-4364] Add Pylint to CI
URL: https://github.com/apache/airflow/pull/5238#issuecomment-489461412
 
 
   I agree the per-line script is pretty messy. I'd be all for making a big 
pylint update (but then a lot of PRs will have merge conflicts). And we will 
have a lot of problems with merging stuff to v1-10* branches. But maybe it's 
worth it :). As long as we provide some tools for all the contributors to 
fix/test their changes locally (like pre-commit hooks), maybe it's the best way 
to implement it. 
   
   It's a bit harsh, but maybe we can run this through community and ask them 
for feedback what they think about it ? I think personally it's the best way of 
introducing such changes - rather than fix everything, give all the 
contributors the tools and support in case of questions (like be ready to 
quickly answer questions - whether we should disable a rule or fix this 
particular case) and let them convert their PRs in a distributed fashion on 
their own.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to