a-nascimento commented on a change in pull request #17996:
URL: https://github.com/apache/airflow/pull/17996#discussion_r741028296
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
+ statsd_on: true
+ statsd_port: ``<port>``
+ statsd_prefix: airflow
+ extraEnv: |-
+ - name: AIRFLOW__METRICS__STATSD_HOST
+ valueFrom:
+ fieldRef:
+ fieldPath: status.hostIP
+
+-OR-
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ extraEnv: |-
+ - name: AIRFLOW__METRICS__STATSD_ON
+ value: "True"
+ - name: AIRFLOW__METRICS__STATSD_PORT
+ value: ``<port>``
+ - name: AIRFLOW__METRICS__STATSD_PREFIX
+ value: "airflow"
+ - name: AIRFLOW__METRICS__STATSD_HOST
+ valueFrom:
+ fieldRef:
+ fieldPath: status.hostIP
+
Review comment:
I agree. If I recall correctly, I initially had issues using the main
`config` block, but I believe it was a user error. I believe I went back and
tested those changes.
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
+ statsd_on: true
+ statsd_port: ``<port>``
Review comment:
I'm fine with that. May want to add a comment to suggest that 8125 is
default for dogstatsd but may differ in deployed environment or something.
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
+ statsd_on: true
+ statsd_port: ``<port>``
+ statsd_prefix: airflow
Review comment:
I'm not sure on this one.
I did it for sake of showing the full block of configuration, didn't want
someone to think it needed to be removed since it's already a part of the helm
chart.
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
Review comment:
I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
