jhtimmins commented on a change in pull request #19294:
URL: https://github.com/apache/airflow/pull/19294#discussion_r741602381



##########
File path: airflow/www/fab_security/sqla/models.py
##########
@@ -178,6 +180,13 @@ def is_active(self):
     def is_anonymous(self):
         return False
 
+    @property
+    def perms(self):
+        perms = set()
+        for role in self.roles:
+            perms.update((perm.action.name, perm.resource.name) for perm in 
role.permissions)

Review comment:
       @andrewgodwin that said, this PR does add some overall time to the 
tests. `pytest tests/views --with-db-init` runs in 1:53 on main and 2:00 on my 
branch. How significant is that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to